Skip to content

[0.2] Fix MSRV compatibility + cut 0.2.4#4750

Draft
TheBlueMatt wants to merge 6 commits into
lightningdevkit:0.2from
TheBlueMatt:2026-06-0.2-msrv
Draft

[0.2] Fix MSRV compatibility + cut 0.2.4#4750
TheBlueMatt wants to merge 6 commits into
lightningdevkit:0.2from
TheBlueMatt:2026-06-0.2-msrv

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Collaborator

dbc5814 broke MSRV for 0.2 which is still 1.63. We fix it here.

@ldk-reviews-bot

Copy link
Copy Markdown

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@TheBlueMatt TheBlueMatt force-pushed the 2026-06-0.2-msrv branch 3 times, most recently from d7ee7f0 to ce77466 Compare June 25, 2026 17:15
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.15%. Comparing base (1fca0ab) to head (347f84f).
⚠️ Report is 61 commits behind head on 0.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.2    #4750      +/-   ##
==========================================
+ Coverage   86.11%   86.15%   +0.03%     
==========================================
  Files         156      158       +2     
  Lines       99952   101287    +1335     
  Branches    99952   101287    +1335     
==========================================
+ Hits        86078    87267    +1189     
- Misses      11380    11515     +135     
- Partials     2494     2505      +11     
Flag Coverage Δ
tests 86.15% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt TheBlueMatt force-pushed the 2026-06-0.2-msrv branch 2 times, most recently from e8c4221 to af6995a Compare June 25, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants